fix: use correct attribute selector syntax in data-slot Tailwind variants#979
Open
mkitti wants to merge 1 commit into
Open
fix: use correct attribute selector syntax in data-slot Tailwind variants#979mkitti wants to merge 1 commit into
mkitti wants to merge 1 commit into
Conversation
…ants [&_data-slot=icon] generates the invalid CSS selector `data-slot=icon`. The correct Tailwind arbitrary variant is [&_[data-slot=icon]], which produces the valid attribute selector `[data-slot=icon]`. Affected files: - packages/react/src/theme/rating.tsx ([&_data-slot=icon] × 4) - packages/react/src/theme/select.tsx ([&_data-slot=placeholder] × 1) Without this fix, esbuild and other CSS minifiers emit css-syntax-error warnings for every project that scans @material-tailwind/react source files, and the styles silently fail in browsers because the selectors are invalid per the CSS spec. Fixes creativetimofficial#860
|
@mkitti is attempting to deploy a commit to the ct-tailwind-team Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
rating.tsxandselect.tsxuse Tailwind arbitrary variants of the form[&_data-slot=icon]. The_in Tailwind arbitrary variants means a descendant space, so this generates the CSS selector:data-slot=iconis not valid CSS — it needs square brackets to be an attribute selector:[data-slot=icon]. Browsers silently skip invalid selectors, so the icon sizing and cursor styles onRatingand the placeholder style onSelectare never applied.This also causes build-tool warnings for every downstream project that scans
@material-tailwind/reactsource files:Reported in issue #860.
Fix
Replace
[&_data-slot=value]with[&_[data-slot=value]]— the nested brackets make[data-slot=value]a proper CSS attribute selector:Files changed:
packages/react/src/theme/rating.tsx— 4 occurrences ([&_data-slot=icon])packages/react/src/theme/select.tsx— 1 occurrence ([&_data-slot=placeholder])Fixes #860