Skip to content

[v3] implement tool package support with validation and config#1196

Merged
crazywhalecc merged 2 commits into
v3from
v3-refactor/tool-pkg
Jun 27, 2026
Merged

[v3] implement tool package support with validation and config#1196
crazywhalecc merged 2 commits into
v3from
v3-refactor/tool-pkg

Conversation

@crazywhalecc

@crazywhalecc crazywhalecc commented Jun 27, 2026

Copy link
Copy Markdown
Owner

What does this PR do?

Notes:

  1. SPC currently cannot distinguish between build dependencies and actual library dependencies; categorizing tools separately helps clarify responsibilities.
  2. This proposal serves as an alternative to [v3] artifact: separate extract and install step #1169. Furthermore, completely separating the "extract" and "install" phases does not seem particularly beneficial at this stage.
  3. This PR currently only declares interfaces, implementations, and classes without refactoring the actual packages; these will be addressed in another PR once the proposed approach is approved.

tool-config.yml

nasm:
  type: tool
  tool:
    provides: [nasm.exe]
    binary-subdir: ''

Checklist before merging

  • If you modified *.php or *.yml, run them locally to ensure your changes are valid:
    • composer cs-fix
    • composer analyse
    • composer test
    • bin/spc dev:lint-config

@henderkes

Copy link
Copy Markdown
Collaborator

Oops, swallowed my comment: seems to do everything I need it to do for the llvm packages. For compiler-rt I'll need to look, maybe need to be able to add runtime hooks.

@crazywhalecc crazywhalecc merged commit 5913cb0 into v3 Jun 27, 2026
8 checks passed
@crazywhalecc crazywhalecc deleted the v3-refactor/tool-pkg branch June 27, 2026 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants