Skip to content

[v3] - fix(windows): define LEXBOR_STATIC for PHP 8.5+ static builds #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
luthermonson wants to merge 1 commit into from
+15 −0
Closed

[v3] - fix(windows): define LEXBOR_STATIC for PHP 8.5+ static builds #1173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/Package/Target/php/windows.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,21 @@ public function makeCgiForWindows(TargetPackage $package, PackageBuilder $builde
$this->deployWindowsBinary($builder, $package, 'php-cgi');
}

#[BeforeStage('php', [self::class, 'makeForWindows'])]
#[PatchDescription('Define LEXBOR_STATIC for static builds (PHP 8.5+ uri extension)')]
public function patchLexborStaticDefine(TargetPackage $package): void
{
if ($this->getPHPVersionID() < 80500) {
return;
}
$makefile_path = "{$package->getSourceDir()}\\Makefile";
$content = FileSystem::readFile($makefile_path);
// ext/uri references lexbor headers which default to __declspec(dllimport) on Windows.
// LEXBOR_STATIC makes LXB_API expand to nothing, required for static linking.
$content = preg_replace('/^CFLAGS_URI=(.+)$/m', 'CFLAGS_URI=$1 /D LEXBOR_STATIC', $content, 1);
FileSystem::writeFile($makefile_path, $content);
}

#[Stage]
public function makeForWindows(TargetPackage $package, PackageInstaller $installer): void
{
Expand Down
Loading