Skip to content

fix(android): remove permission check when opening apk files #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ipcjs wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(android): remove permission check when opening apk files #350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions open_file_android/android/src/main/java/com/crazecoder/openfile/OpenFilePlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,6 @@ public class OpenFilePlugin implements MethodCallHandler

private int REQUEST_CODE_FOR_DIR = 0x111;

private static final String TYPE_STRING_APK = "application/vnd.android.package-archive";

@Override
public void onMethodCall(MethodCall call, @NonNull Result result) {
isResultSubmitted = false;
Expand Down Expand Up @@ -112,10 +110,6 @@ private void doOpen() {

}
}
if (TYPE_STRING_APK.equals(mimeType)) {
openApkFile();
return;
}
startActivity();
}

Expand Down Expand Up @@ -166,24 +160,6 @@ private void startActivity() {
result(type, message);
}

private void openApkFile() {
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O && !canInstallApk()) {
result(-3, "Permission denied: " + Manifest.permission.REQUEST_INSTALL_PACKAGES);
} else {
startActivity();
}
}

@RequiresApi(api = Build.VERSION_CODES.O)
private boolean canInstallApk() {
try {
return activity.getPackageManager().canRequestPackageInstalls();
} catch (SecurityException e) {
e.printStackTrace();
return false;
}
}

private void result(int type, String message) {
if (result != null && !isResultSubmitted) {
Map<String, Object> map = MapUtil.createMap(type, message);
Expand Down