[5.7] Order Edit - shipping methods load on demand#4311
Open
nfourtythree wants to merge 6 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves Order Edit performance by removing eager shipping method option loading from the order payload and instead fetching shipping method options only when the user chooses to edit the shipping method.
Changes:
- Removed
availableShippingMethodOptionsfrom the default order JSON payload and added a new controller action to fetch options on demand. - Updated the shipping method UI to show the current method (name/handle) and fetch options only after clicking “Edit”.
- Added support for submitting
shippingMethodNamealongsideshippingMethodHandlefrom the UI.
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/web/assets/commerceui/src/js/order/store/index.js | Stores shipping method options separately and exposes them via a getter. |
| src/web/assets/commerceui/src/js/order/helpers/utils.js | Adds shippingMethodName into draft payload sent to the server. |
| src/web/assets/commerceui/src/js/order/components/meta/ShippingMethod.vue | Switches shipping method selection to an on-demand edit flow with API fetch and local display. |
| src/web/assets/commerceui/src/js/order/api/orders.js | Adds a client API call for fetching shipping method options. |
| src/controllers/OrdersController.php | Adds actionGetShippingMethodOptions(), removes eager shipping options from _orderToArray(), and updates shipping method name handling. |
| CHANGELOG-WIP.md | Documents the new controller action. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a performance improvement to load shipping methods on request. This helps projects that have large number of methods and/or rules