default title format and first save of nested elements#19012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In some cases, the title of the nested element with a default title format isn’t updated on the first full save.
What happens is: when the root Entry is saved, the
ElementsController::actionApplyDraft()is called, and it’ll eventually get toNestedElementManager::duplicateNestedEntries(), which will save the element (Elements::_saveElementInternal()).That'll trigger
Entry::beforeSave()and finallyEntry::updateTitle().But when
updateTitle()is called frombeforeSave(), the canonical nested entry that’s being saved doesn’t have its final ID yet. So if you’re usingpt-{object.id}as yourtitleFormat, the template will resolve topt-.Fixed by adding a new
Element::afterNewRecordSaved()method.Related issues
#18991