account for getEntryTypesByHandle returning an array #18226
+29
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In v3, we briefly dropped support for passing an array of entry types into the type param. It was then re-added in 3.7.40 via 54a3959 (related issue: #11057).
However, up until and including v4, the
Sections->getEntryTypesByHandle()method, which is used in the normalisation of theEntryQuery->type()param, only returns an array, which means that using it with anything other than an EntryType model always triggers a call to the database.This PR takes into consideration that
Sections->getEntryTypesByHandle()can return an array of entry types, and it does lower the number of DB queries, but I’m not 100% sure if it’s worth the extra code complexity.This issue only affects v4, as in v5, entry type handles are globally unique.
Related issues
#18223