c: changed std::string_view to char* in WAD3.h#101
Merged
craftablescience merged 2 commits intocraftablescience:mainfrom Mar 19, 2026
Merged
c: changed std::string_view to char* in WAD3.h#101craftablescience merged 2 commits intocraftablescience:mainfrom
craftablescience merged 2 commits intocraftablescience:mainfrom
Conversation
craftablescience
requested changes
Mar 19, 2026
Owner
There was a problem hiding this comment.
You need to change the cpp declaration as well
lang/c/src/vpkppc/format/WAD3.cpp L8-10
-const int8_t VPKPP_WAD3_FILENAME_MAX_SIZE = WAD3_FILENAME_MAX_SIZE;
-const uint32_t VPKPP_WAD3_SIGNATURE = WAD3_SIGNATURE;
-const std::string_view VPKPP_WAD3_EXTENSION = WAD3_EXTENSION.data();
+const int8_t VPKPP_WAD3_FILENAME_MAX_SIZE = WAD3_FILENAME_MAX_SIZE;
+const uint32_t VPKPP_WAD3_SIGNATURE = WAD3_SIGNATURE;
+const char* VPKPP_WAD3_EXTENSION = WAD3_EXTENSION.data();
Contributor
Author
|
Sorry about that, when I compiled this and did a small test in C to see if it worked, nothing complained so I didn't notice that they were also declared in the cpp file. Should be fixed now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does as the title says