Fix large graph resolution collapse - #240
Merged
Merged
Conversation
forhappy
marked this pull request as ready for review
August 14, 2026 00:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
universal_resolution_partialgraph diagnostic for omissionsRoot cause
On stablyai/orca at commit ee8dd4796e39d77b1c2c19d6962430e901244bea, Compass collected 1,274,411 universal declarations, exceeding the resolver hard limit of 1,000,000. The resolver stored the error on the intermediate extraction, but the build pipeline still published success with mostly file scaffolding: 135,071 nodes and 2,377 edges.
Impact
A default-low Orca qualification after this change completed without degraded resolution and produced 866,633 nodes and 1,785,277 edges. It compacted 542,848 unused leaf declarations while preserving referenced parameters and properties. If a still-larger repository cannot fit the aggregate resolver after compaction, Compass now keeps all retained declarations, resolves only adapter-proven exact relationships in deterministic partitions, records omissions, and exits nonzero instead of silently presenting a collapsed graph as complete.
The successful Orca run took 320.60 seconds total: 258.3 seconds deterministic extraction and 58.2 seconds publication. Build and query latency were not optimization criteria for this fix.
Validation
cargo fmt --all -- --checkcargo clippy --workspace --lib --bins --locked -- -D warningscargo test --workspace --lib --bins --lockedsh scripts/check_product_boundary.sh./scripts/qualify_code_graph_v1.sh --fixtures-only: 57 languages, all semantic assertions and deterministic byte comparisons passedresolution_degraded: false