Fix #14949: FP leakNoVarFunctionCall when passing resource to constructor - #8765
Open
aadanen wants to merge 2 commits into
Open
Fix #14949: FP leakNoVarFunctionCall when passing resource to constructor#8765aadanen wants to merge 2 commits into
aadanen wants to merge 2 commits into
Conversation
Author
|
clang-tidy/build fails with sanitizers/build fails with a timeout. As I anticipated this solution is too slow. I will think about how to make it faster. |
Collaborator
It does that all the time, I'll rerun it later... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove Variable and AllocType type checking when searching for unreleased arguments and when checking if member variables are deallocated in destructor.
This method is a little heavy handed and might hurt performance, but I am unsure how we could be more precise. It would be nice if we could check "If var.isResource() or var.needsToBeDeallocated()" but that would be a different PR i think.