refs #14593 - improved string concatenation in ScopeInfo3 constructor

[firewave]

No description provided.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[firewave]

Analyzing https://github.com/WinterSnowfall/d7vk/blob/1b4d4f0d87e1c04061a6899e03d4f0e426e2d545/src/ddraw/d3d3/d3d3_device.cpp with -D_MSC_VER.

Clang 21 - 3,349,539,134 -> 3.329,173,343
GCC 15 - 3,322,719,077 -> 3,300,326,424

Would be good to have a check to detect such code.

[firewave]

Callgrind in CI: 54,573,693,766 -> 54,544,753,190

[chrchr-github]

Would be good to have a check to detect such code.

Related: https://trac.cppcheck.net/ticket/12857

[firewave]

Would be good to have a check to detect such code.

Related: https://trac.cppcheck.net/ticket/12857

Added https://trac.cppcheck.net/ticket/12857#comment:10. Will file an upstream ticket later.

[danmar]

I think the code is uglier and less readable :-(
speed is really important so I approve this.
but I am wondering if there is some alternative to tweak the code in release builds instead.
something like the matchCompiler but with type information would be needed.

[firewave]

Matchcompiling would be undesired as we would lose the improvements in regular (and non-release) builds (which is why I tried to separate out some cases in the past).

I do not like the decreased readability either so I thought about adding a helper instead. I will propose that in a separate PR as I am not sure about the parameters yet and I am also very bad an varargs.