fix: define MRDOCS_NO_UNIQUE_ADDRESS and MRDOCS_DOM_NO_UNIQUE_ADDRESS correctly - #1255
Open
gennaroprota wants to merge 1 commit into
Conversation
… correctly The macro definitions were guarded by `__cpp_lib_no_unique_address`, which does not exist, so they expanded to nothing on all compilers. Also, MSVC has its own version of the attribute (`msvc::no_unique_address`) and does not support the standard one.
|
| Scope | Lines Δ% | Lines Δ | Lines + | Lines - | Files Δ | Files + | Files ~ | Files ↔ | Files - |
|---|---|---|---|---|---|---|---|---|---|
| 🛠️ Source | 100% | 10 | 8 | 2 | 2 | - | 2 | - | - |
| Total | 100% | 10 | 8 | 2 | 2 | - | 2 | - | - |
Legend: Files + (added), Files ~ (modified), Files ↔ (renamed), Files - (removed)
🔝 Top Files
- include/mrdocs/Platform.hpp (Source): 5 lines Δ (+4 / -1)
- libs/dom/include/mrdocs/Dom/Platform.hpp (Source): 5 lines Δ (+4 / -1)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1255 +/- ##
========================================
Coverage 83.12% 83.12%
========================================
Files 35 35
Lines 3662 3662
Branches 844 844
========================================
Hits 3044 3044
Misses 410 410
Partials 208 208
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
An automated preview of the documentation is available at https://1255.mrdocs.prtest2.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-08-17 20:04:11 UTC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macro definitions were guarded by
__cpp_lib_no_unique_address, which does not exist, so they expanded to nothing on all compilers. Also, MSVC has its own version of the attribute (msvc::no_unique_address) and does not support the standard one.Changes
__has_cpp_attributeis used to select the correct definition.Testing
We don't usually test macro definitions like those.
Documentation
The macros are implementation details, so no documentation update is needed.