-
Notifications
You must be signed in to change notification settings - Fork 23
chore: bump LLVM to 77e43ec1 (May 21, 2026) #1241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,11 +42,16 @@ jobs: | |
| standards: '23' | ||
| main-entry-factors: | | ||
| clang Coverage | ||
| # MSan builds an instrumented libc++ from the pinned LLVM sources, | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don’t like some of the excessive comments that likely come from using AI. The thing with AI is that it doesn’t know how to not say things. For instance, you tell AI to not say “X” and very often it gives you text like “I’m not even going to bring up X”. Because it’s a text-generating machine. It has no button for not generating text. For instance, in this particular PR, it’s obvious AI was moving MSan to latest-factors and felt like it just to justify this in a comment. The comment is coherent with what it had in its context but it’s not coherent with the rest of the code. After this is merged, a person reading this file doesn’t know this context. This looks like it’s documentation for latest-factors and makes no sense there. The user wouldn’t even know this option was not in latest-factors before. The user won’t understand why msan and not latest-factors is explained here. They won’t understand why this is the only factor singled-out and so on. |
||
| # which only a recent Clang can compile, so keep it on the latest | ||
| # Clang; an older one (such as 20) fails to build it. ASan does not | ||
| # build libc++ (bootstrap builds it for MSan only), so it can stay | ||
| # distributed. | ||
| latest-factors: | | ||
| clang UBSan | ||
| clang UBSan MSan | ||
| factors: | | ||
| gcc UBSan | ||
| clang ASan MSan | ||
| clang ASan | ||
| apple-clang UBSan ASan | ||
| build-types: | | ||
| gcc: Release | ||
|
|
@@ -75,14 +80,8 @@ jobs: | |
| append-common-cxxflags: | | ||
| clang: -gz=zstd | ||
| extra-values: | | ||
| # libc++ runtimes: clang + (ASan or MSan) needs instrumented libc++ | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why are these gone? Weren't they being used? Interesting. I thought we used the custom libc++ whenever we had msan or asan. It it because the logic for this necessity is now being checked in the bootstrap script? |
||
| # built separately from the main LLVM build | ||
| use-libcxx: {{and (ieq compiler 'clang') (or msan asan)}} | ||
| libcxx-runtimes: {{select (ne compiler 'msvc') "libcxx;libcxxabi" "libcxx"}} | ||
| llvm-runtimes: {{{select (ine use-libcxx 'true') libcxx-runtimes ""}}} | ||
|
|
||
| # LLVM build configuration | ||
| llvm-hash: dc4cef81d47c7bc4a3c4d58fbacf8a6359683fae | ||
| llvm-hash: 77e43ec11cd8fbe1de491118b54de9bba94510a8 | ||
| llvm-short-hash: {{{substr llvm-hash 0 7}}} | ||
| llvm-preset-build-type: {{{lowercase build-type}}} | ||
| llvm-preset-os: {{select (ieq os 'windows') "win" "unix"}} | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,29 +12,7 @@ | |
| #define MRDOCS_SHARE_HEADERS_LIBC_STUBS_NEW_H | ||
|
|
||
| #if defined(_LIBCPP_ABI_VCRUNTIME) | ||
| namespace std { | ||
| enum class align_val_t : size_t {}; | ||
| struct nothrow_t { explicit nothrow_t() = default; }; | ||
| extern const std::nothrow_t nothrow; | ||
| } | ||
|
|
||
| // Replaceable allocation functions | ||
| void* operator new ( std::size_t count ); | ||
| void* operator new[]( std::size_t count ); | ||
| void* operator new ( std::size_t count, std::align_val_t al ); | ||
| void* operator new[]( std::size_t count, std::align_val_t al ); | ||
|
|
||
| // Replaceable non-throwing allocation functions | ||
| void* operator new ( std::size_t count, const std::nothrow_t& tag ); | ||
| void* operator new[]( std::size_t count, const std::nothrow_t& tag ); | ||
| void* operator new ( std::size_t count, std::align_val_t al, | ||
| const std::nothrow_t& tag ) noexcept; | ||
| void* operator new[]( std::size_t count, std::align_val_t al, | ||
| const std::nothrow_t& tag ) noexcept; | ||
|
|
||
| // Non-allocating placement allocation functions | ||
| void* operator new ( std::size_t count, void* ptr ); | ||
| void* operator new[]( std::size_t count, void* ptr ); | ||
| #include <vcruntime_new.h> | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Interesting. Is this something being fixed in passing or do we have something about the new version that interacts with the libc stubs? In fact, I would have this question about all other changes to the libc stubs. It's unexpected to me that they interacted in an LLVM bump. |
||
| #endif | ||
|
|
||
| #endif // MRDOCS_SHARE_HEADERS_LIBC_STUBS_NEW_H | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| // | ||
| // Licensed under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| // Copyright (c) 2024 Alan de Freitas (alandefreitas@gmail.com) | ||
| // | ||
| // Official repository: https://github.com/cppalliance/mrdocs | ||
| // | ||
|
|
||
| #ifndef MRDOCS_SHARE_HEADERS_LIBC_STUBS_VCRUNTIME_NEW_H | ||
| #define MRDOCS_SHARE_HEADERS_LIBC_STUBS_VCRUNTIME_NEW_H | ||
|
|
||
| // libc++ includes this Microsoft runtime header (through <__new/align_val_t.h>) | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This whole comment, especially "Provide just enough of it for parsing." seems redundant because this is true for all stubs by definition. They're headers libc++ includes for its own functionality and we provide only enough for parsing. |
||
| // when built for the vcruntime ABI, so that std::align_val_t is layout-compatible | ||
| // with the platform. Provide just enough of it for parsing. | ||
| namespace std { | ||
| enum class align_val_t : size_t {}; | ||
| struct nothrow_t { explicit nothrow_t() = default; }; | ||
| extern const std::nothrow_t nothrow; | ||
| } | ||
|
|
||
| // Replaceable allocation functions | ||
| void* operator new ( std::size_t count ); | ||
| void* operator new[]( std::size_t count ); | ||
| void* operator new ( std::size_t count, std::align_val_t al ); | ||
| void* operator new[]( std::size_t count, std::align_val_t al ); | ||
|
|
||
| // Replaceable non-throwing allocation functions | ||
| void* operator new ( std::size_t count, const std::nothrow_t& tag ); | ||
| void* operator new[]( std::size_t count, const std::nothrow_t& tag ); | ||
| void* operator new ( std::size_t count, std::align_val_t al, | ||
| const std::nothrow_t& tag ) noexcept; | ||
| void* operator new[]( std::size_t count, std::align_val_t al, | ||
| const std::nothrow_t& tag ) noexcept; | ||
|
|
||
| // Non-allocating placement allocation functions | ||
| void* operator new ( std::size_t count, void* ptr ); | ||
| void* operator new[]( std::size_t count, void* ptr ); | ||
|
|
||
| #endif // MRDOCS_SHARE_HEADERS_LIBC_STUBS_VCRUNTIME_NEW_H | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What’s this profraw issue? The explanation is more descriptive than explanatory of the motivation of the command. It seems to me like if this is happening and coverage is globing the wrong directory, that’s what should be fixed instead of a second workaround to accommodate the first mistake.