Skip to content

Suppress confusing TLS provider warnings (#183)#184

Merged
sgerbino merged 1 commit intocppalliance:developfrom
sgerbino:pr/dependencies
Mar 2, 2026
Merged

Suppress confusing TLS provider warnings (#183)#184
sgerbino merged 1 commit intocppalliance:developfrom
sgerbino:pr/dependencies

Conversation

@sgerbino
Copy link
Collaborator

@sgerbino sgerbino commented Mar 2, 2026

find_package for optional TLS providers (OpenSSL, WolfSSL) produced alarming "Could NOT find" messages that made them appear required. Use QUIET and print a status message only when found.

Related to #183.

Summary by CodeRabbit

  • Chores
    • Improved build system to provide clearer status messages for TLS support availability and prevent unnecessary build interruptions when optional packages are unavailable.

find_package for optional TLS providers (OpenSSL, WolfSSL) produced
alarming "Could NOT find" messages that made them appear required.
Use QUIET and print a status message only when found.
@coderabbitai
Copy link

coderabbitai bot commented Mar 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 534f963 and 478b012.

📒 Files selected for processing (1)
  • cmake/CorosioBuild.cmake

📝 Walkthrough

Walkthrough

The corosio_find_tls_provider function in CMake now uses the QUIET flag with find_package to suppress errors when TLS provider packages aren't found. When found, a status message is emitted. Conditional logic ensures TLS library creation only proceeds if the package is successfully located.

Changes

Cohort / File(s) Summary
CMake Build Configuration
cmake/CorosioBuild.cmake
Added QUIET flag to find_package calls for graceful handling of missing TLS packages; added conditional status message on successful package detection.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 With whispers soft, we search the night,
For packages hiding out of sight,
QUIET now, no error's cry,
When found, a message to the sky!
Build flow cleaner, smooth and bright.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: suppressing confusing TLS provider warnings by using QUIET mode in find_package calls.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://184.corosio.prtest3.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-03-02 19:01:05 UTC

@cppalliance-bot
Copy link

GCOVR code coverage report https://184.corosio.prtest3.cppalliance.org/gcovr/index.html
LCOV code coverage report https://184.corosio.prtest3.cppalliance.org/genhtml/index.html
Coverage Diff Report https://184.corosio.prtest3.cppalliance.org/diff-report/index.html

Build time: 2026-03-02 19:08:37 UTC

@sgerbino sgerbino merged commit 49f76ca into cppalliance:develop Mar 2, 2026
20 checks passed
@sgerbino sgerbino deleted the pr/dependencies branch March 2, 2026 19:16
@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.48%. Comparing base (534f963) to head (478b012).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #184      +/-   ##
===========================================
+ Coverage    76.45%   76.48%   +0.02%     
===========================================
  Files          101      101              
  Lines        10552    10593      +41     
  Branches      2389     2389              
===========================================
+ Hits          8068     8102      +34     
- Misses        1762     1771       +9     
+ Partials       722      720       -2     
Flag Coverage Δ
linux 83.55% <ø> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 20 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 534f963...478b012. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants