Skip to content

refactor(jsonl-parser): replace _parse_tool_result if/elif with dispa… #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clean6378-max-it wants to merge 3 commits into
base: master
Choose a base branch
from
+254 −126
Open

refactor(jsonl-parser): replace _parse_tool_result if/elif with dispa… #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce95de9
refactor(jsonl-parser): replace _parse_tool_result if/elif with dispa…
clean6378-max-it May 6, 2026
8ceb7cc
fix(jsonl-parser): safe web_search result_count + slug Optional typin…
clean6378-max-it May 6, 2026
06d0388
docs: align Issue 29 guide with PR framing for #29
clean6378-max-it May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tests/test_jsonl_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,13 @@ def test_web_search_result(self):
assert r["query"] == "q"
assert r["result_count"] == 1

def test_web_search_results_none_or_non_sized_yields_zero_count(self):
r = _parse_tool_result({"query": "q", "results": None})
assert r["result_type"] == "web_search"
assert r["result_count"] == 0
r2 = _parse_tool_result({"query": "q", "results": "not-a-list"})
assert r2["result_count"] == 0
Comment thread
clean6378-max-it marked this conversation as resolved.

def test_web_fetch_result(self):
r = _parse_tool_result({"url": "https://x", "code": 200, "durationMs": 40})
assert r["result_type"] == "web_fetch"
Expand Down
Loading
Loading