refactor!: rename continuation::next to reserved (void*) (#344)#346
Merged
mvandeberg merged 1 commit intoJun 30, 2026
Merged
Conversation
…#344) The public `next` member of `capy::continuation` over-promised an intrusive-list contract the library does not offer to users: the field is clobbered on submission to the executor and carries no meaning afterward. Rename it to `reserved` and retype it from `continuation*` to `void*` so the name matches the real semantics -- "don't touch" for ordinary users, and a single pre-submission scratch slot that coroutine-machinery authors may commandeer for their own node-based structures. The internal intrusive queues (thread_pool, strand_queue, and the priority_executor test) still link continuations through this slot; writes convert to void* implicitly and the three read sites cast back with static_cast<continuation*>.
|
An automated preview of the documentation is available at https://346.capy.prtest3.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-06-30 20:58:09 UTC |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop-2 #346 +/- ##
============================================
Coverage ? 98.29%
============================================
Files ? 77
Lines ? 3984
Branches ? 0
============================================
Hits ? 3916
Misses ? 68
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The public
nextmember ofcapy::continuationover-promised an intrusive-list contract the library does not offer to users: the field is clobbered on submission to the executor and carries no meaning afterward. Rename it toreservedand retype it fromcontinuation*tovoid*so the name matches the real semantics -- "don't touch" for ordinary users, and a single pre-submission scratch slot that coroutine-machinery authors may commandeer for their own node-based structures.The internal intrusive queues (thread_pool, strand_queue, and the priority_executor test) still link continuations through this slot; writes convert to void* implicitly and the three read sites cast back with static_cast<continuation*>.