refactor!: remove DynamicBuffer concept and read_until#343
Conversation
|
An automated preview of the documentation is available at https://343.capy.prtest3.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-06-30 17:27:57 UTC |
sgerbino
force-pushed
the
pr/remove-dynamic-buffer
branch
from
05a9492 to
d411c45
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop-2 #343 +/- ##
============================================
Coverage ? 98.29%
============================================
Files ? 77
Lines ? 3984
Branches ? 0
============================================
Hits ? 3916
Misses ? 68
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
With this removal, value |
Very good catch, you're right. I'm removing them as well. |
Remove the DynamicBuffer subsystem and the read_until algorithm as a self-contained unit. Nothing in the surviving library consumed these beyond the dynamic read overloads and read_until themselves. Removed: - DynamicBuffer / DynamicBufferParam concepts - read_until and the MatchCondition concept it required (no other consumer) - flat_/circular_/vector_/string_dynamic_buffer types and their factory - the two dynamic read overloads (read-until-eof into a growable buffer) The counted read(stream, MutableBufferSequence) overload is unchanged: it fills a fixed buffer sequence and remains fully covered by tests. BREAKING CHANGE: dynamic buffers, read_until, and the growable-buffer read overloads are no longer part of the public API.
sgerbino
force-pushed
the
pr/remove-dynamic-buffer
branch
from
d411c45 to
a4c48f7
Compare
3 participants
Remove the DynamicBuffer subsystem and the read_until algorithm as a self-contained unit. Nothing in the surviving library consumed these beyond the dynamic read overloads and read_until themselves.
Removed:
The counted read(stream, MutableBufferSequence) overload is unchanged: it fills a fixed buffer sequence and remains fully covered by tests.
BREAKING CHANGE: dynamic buffers, read_until, and the growable-buffer read overloads are no longer part of the public API.