refactor(buffers): split slicing from consumption#338
Merged
Conversation
buffer_slice now returns a value (slice_type<X>): a buffer for a single buffer self-slice, otherwise a borrowed slice_of<X> view. The result is a buffer sequence directly, with no .data() and no Slice concept to bind. slice_of<X> constructs in a single forward pass to the cut points. Consumption moves to a dedicated consuming_buffers cursor: data() exposes the remaining bytes and consume(n) advances in place. It borrows the sequence and is not itself a buffer sequence. read, write, and write_now drive it. Removes the now-unused Slice/MutableSlice concepts and slice_impl.
|
An automated preview of the documentation is available at https://338.capy.prtest3.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-06-24 21:53:03 UTC |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop-2 #338 +/- ##
============================================
Coverage ? 98.39%
============================================
Files ? 83
Lines ? 4233
Branches ? 0
============================================
Hits ? 4165
Misses ? 68
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buffer_slice now returns a value (slice_type): a buffer for a single buffer self-slice, otherwise a borrowed slice_of view. The result is a buffer sequence directly, with no .data() and no Slice concept to bind. slice_of constructs in a single forward pass to the cut points.
Consumption moves to a dedicated consuming_buffers cursor: data() exposes the remaining bytes and consume(n) advances in place. It borrows the sequence and is not itself a buffer sequence. read, write, and write_now drive it.
Removes the now-unused Slice/MutableSlice concepts and slice_impl.