Skip to content

[simd.math,simd.reductions] Fix undeclared identifiers in std::simd #9145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhinavagarwal07 wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −4
Open

[simd.math,simd.reductions] Fix undeclared identifiers in std::simd #9145

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2413390
[simd.math,simd.reductions] Fix two undeclared identifiers in std::simd
abhinavagarwal07 Jun 17, 2026
b407170
[simd.reductions] Name x and mask parameters in masked reduce_min/red…
abhinavagarwal07 Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions source/numerics.tex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18926,7 +18926,7 @@
\begin{itemdecl}
template<class T, class Abi>
constexpr T reduce_min(
const basic_vec<T, Abi>&, const typename basic_vec<T, Abi>::mask_type&) noexcept;
const basic_vec<T, Abi>& x, const typename basic_vec<T, Abi>::mask_type& mask) noexcept;
\end{itemdecl}

\begin{itemdescr}
Expand Down Expand Up @@ -18963,7 +18963,7 @@
\begin{itemdecl}
template<class T, class Abi>
constexpr T reduce_max(
const basic_vec<T, Abi>&, const typename basic_vec<T, Abi>::mask_type&) noexcept;
const basic_vec<T, Abi>& x, const typename basic_vec<T, Abi>::mask_type& mask) noexcept;
\end{itemdecl}

\begin{itemdescr}
Expand All @@ -18974,7 +18974,7 @@
\pnum
\returns
If \tcode{none_of(mask)} is \tcode{true}, returns
\tcode{numeric_limits<V::value_type>::lowest()}.
\tcode{numeric_limits<T>::lowest()}.

@jensmaurer jensmaurer Jun 17, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct. @mattkretz , please have a look.

@mattkretz mattkretz Jun 17, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Otherwise, returns the value of a selected element \tcode{x[$j$]} for which
\tcode{x[$j$] < x[$i$]} is \tcode{false} for all selected indices $i$ of
\tcode{mask}.
Expand Down Expand Up @@ -20537,7 +20537,7 @@
Let \tcode{\placeholder{modf-vec}} denote:
\begin{codeblock}
pair<V, V> @\placeholder{modf-vec}@(const V& x) {
T r1[Ret::size()];
T r1[V::size()];
V r0([&](@\exposid{simd-size-type}@ i) {
return modf(V(x)[i], &r1[i]);
});
Expand Down
Loading