[2026-06 LWG Motion 3] P3798R1 The unexpected in std::expected#9127
Open
eisenwave wants to merge 1 commit into
Open
[2026-06 LWG Motion 3] P3798R1 The unexpected in std::expected#9127eisenwave wants to merge 1 commit into
eisenwave wants to merge 1 commit into
Conversation
eisenwave
changed the title
jwakely
reviewed
Jun 23, 2026
Comment on lines
+9430
to
+9432
| \begin{codeblock} | ||
| return !has_value(); | ||
| \end{codeblock} |
Member
There was a problem hiding this comment.
I don't think this needs to be a codeblock, does it?
Suggested change
| \begin{codeblock} | |
| return !has_value(); | |
| \end{codeblock} | |
| \tcode{return !has_value();} |
(Also I wonder why we didn't ask for it to be just Returns: !has_value() since there are no preconditions or other special effects of has_value() that we need to inherit here.
Comment on lines
+10473
to
+10475
| \begin{codeblock} | ||
| return !has_value(); | ||
| \end{codeblock} |
Member
There was a problem hiding this comment.
Suggested change
| \begin{codeblock} | |
| return !has_value(); | |
| \end{codeblock} | |
| \tcode{return !has_value();} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9090
Also fixes cplusplus/papers#2403