Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughBulk localization updates across apps/cowswap-frontend: many .po files had translation text additions/edits, PO-Revision-Date bumps, and widespread relocation/renaming of translation source reference paths; no functional code or exported API signature changes. Changes
Sequence Diagram(s)(omitted) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can make CodeRabbit's review stricter and more nitpicky using the `assertive` profile, if that's what you prefer.Change the |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@apps/cowswap-frontend/src/locales/ru-RU.po`:
- Around line 6597-6600: Update the Russian translation for the msgid in
LoadMoreOrdersSection (OrdersTableContainer) to fix grammar and spacing: replace
the current msgstr with a grammatically correct string using the plural form
"открытых ордеров" and remove the extra space after "Найдено" (e.g. "Найдено
{totalOpenOrders} открытых ордеров в списке {limit} последних.").
- Around line 5366-5368: The Russian translation for the protocol fee banner
(msgid in
apps/cowswap-frontend/src/modules/limitOrders/pure/ProtocolFeeInfoBanner/index.tsx)
omits the crucial clause about orders "executed after this time, even if they
were created earlier"; update msgstr to mirror the source by adding a literal
equivalent of "исполненные после этого времени, даже если они были созданы
ранее" while preserving the existing placeholders
{PROTOCOL_FEE_START_DATETIME_UTC} and the HTML tags <0> and <1> so the final
string reads logically and matches the source meaning.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@apps/cowswap-frontend/src/locales/es-ES.po`:
- Around line 5558-5561: The Spanish translation for msgid "Cross-chain swaps
are here" in the translation entry used by the CrossChainUnlockScreen component
is incorrect; update the msgstr (currently "Los swaps de cadena media están
aquí") to use a correct rendering like "Los swaps entre cadenas están aquí" (or
"Los swaps multicadena están aquí") so the msgid -> msgstr mapping conveys
"cross‑chain" properly.
| #: apps/cowswap-frontend/src/modules/swap/pure/CrossChainUnlockScreen/index.tsx | ||
| msgid "Cross-chain swaps are here" | ||
| msgstr "Los swaps entre cadenas están aquí" | ||
| msgstr "Los swaps de cadena media están aquí" | ||
|
|
There was a problem hiding this comment.
Translation for “Cross-chain” is inaccurate.
“cadena media” doesn’t convey “cross‑chain.” Prefer “entre cadenas” or “multicadena.”
🔧 Suggested fix
-msgstr "Los swaps de cadena media están aquí"
+msgstr "Los swaps entre cadenas ya están aquí"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| #: apps/cowswap-frontend/src/modules/swap/pure/CrossChainUnlockScreen/index.tsx | |
| msgid "Cross-chain swaps are here" | |
| msgstr "Los swaps entre cadenas están aquí" | |
| msgstr "Los swaps de cadena media están aquí" | |
| #: apps/cowswap-frontend/src/modules/swap/pure/CrossChainUnlockScreen/index.tsx | |
| msgid "Cross-chain swaps are here" | |
| msgstr "Los swaps entre cadenas ya están aquí" | |
🤖 Prompt for AI Agents
In `@apps/cowswap-frontend/src/locales/es-ES.po` around lines 5558 - 5561, The
Spanish translation for msgid "Cross-chain swaps are here" in the translation
entry used by the CrossChainUnlockScreen component is incorrect; update the
msgstr (currently "Los swaps de cadena media están aquí") to use a correct
rendering like "Los swaps entre cadenas están aquí" (or "Los swaps multicadena
están aquí") so the msgid -> msgstr mapping conveys "cross‑chain" properly.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@apps/cowswap-frontend/src/locales/en-US.po`:
- Around line 3302-3304: Singular/plural mismatch: the string in
LoadMoreOrdersSection.tsx uses "Found 1 open order in the {limit} most recent
ones." which reads wrong when {limit} != 1; change the source to avoid
"one...one" by either (A) rephrasing the literal to always use the plural form
for the window (e.g., "Found {count} open order(s) in the {limit} most recent
orders") or (B) implement proper i18n pluralization for the message (provide
both singular and plural variants in the component that renders the message and
re-run extraction), then update the .po entries (msgid/msgid_plural and
msgstr[n]) accordingly for the message referenced in LoadMoreOrdersSection.tsx
so translations reflect correct singular/plural for both the order count and the
{limit} phrase.
| #: apps/cowswap-frontend/src/modules/ordersTable/pure/OrdersTable/LoadMore/Section/LoadMoreOrdersSection.tsx | ||
| msgid "Found 1 open order in the {limit} most recent ones." | ||
| msgstr "Found 1 open order in the {limit} most recent ones." |
There was a problem hiding this comment.
Avoid singular/plural mismatch in limit-based “most recent” strings.
These read awkwardly when {limit} isn’t 1 (e.g., “the 1 most recent one”). Consider rephrasing to “the {limit} most recent orders” or providing singular/plural variants in the source and re-extracting translations.
Also applies to: 4625-4627
🤖 Prompt for AI Agents
In `@apps/cowswap-frontend/src/locales/en-US.po` around lines 3302 - 3304,
Singular/plural mismatch: the string in LoadMoreOrdersSection.tsx uses "Found 1
open order in the {limit} most recent ones." which reads wrong when {limit} !=
1; change the source to avoid "one...one" by either (A) rephrasing the literal
to always use the plural form for the window (e.g., "Found {count} open order(s)
in the {limit} most recent orders") or (B) implement proper i18n pluralization
for the message (provide both singular and plural variants in the component that
renders the message and re-run extraction), then update the .po entries
(msgid/msgid_plural and msgstr[n]) accordingly for the message referenced in
LoadMoreOrdersSection.tsx so translations reflect correct singular/plural for
both the order count and the {limit} phrase.
2 participants
Summary by CodeRabbit