Conversation
|
Ben, want me to um write a test for this or something? |
|
Beatport.com users can't complete the checkout process because of this sniff now too. 😞 |
|
We're patched now at Beatport. Thanks for the fix! |
|
I was about to make the same pull request, Opera now supports postMesage. Ben, are you alive? =) /JT |
|
+1 on this from me too! |
|
Yet another +1. |
|
Another +1 here. |
|
And another +1 from me. |
|
for Opera, use window.addEventListener('message', callback, false) instead of window.addEventListener('message', callback, !1) I checked on opera 12, it doesn't work when we pass !1 as third argument of addEventListener method |
|
If not removed this "sniffing" statement should be modified for compatibility with jQuery 1.9.x+ as $.browser is deprecated now. |
|
👍 |
1 similar comment
|
👍 |
|
Further to this I have modified the browser sniff so that it does not fail on jQuery 1.9.x+ and I have added a note to the README to use the jQuery.browser plugin. |
|
hi ben, miss u. ❤️ |
|
Yesss! |
|
🎂 happy bday PR |
SUP BEN.
Opera 9.64 is like, 9 versions old. I know Ryan has a fork that normalizes its old document.postMessage implementation--but I think that's going to help like 0.01% of all Opera users. So....this is easier and won't break any sites or provide a crappy fallback for current Opera users.