Speed up continuous Reader scanning on Android - #52
Merged
Conversation
…reader-scan-cleanup # Conflicts: # README.md # android/build.gradle # android/src/main/java/expo/modules/blenfcreader/ReactNativeBleNfcReaderModule.kt # ios/ReactNativeBleNfcReader.podspec # package.json # src/android-native-contract.test.ts
djwok
marked this pull request as ready for review
July 29, 2026 10:16
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The prior Android implementation rotated five model-specific ACS scans sequentially. With a five-second window per model, an ACR1555U could take roughly 20–25 seconds to appear.
The first parallel implementation registered five Android BLE scans per session. Android throttles frequent scan registrations, so stopping and immediately starting again could fail silently inside the ACS wrapper.
This change instead registers one platform BLE scan with filters for all five ACS service UUIDs. It stops and clears that exact callback on stop, connect, or lifecycle cleanup, reports
onScanFailed, and uses the patched ACS terminal factory for discovered devices.Validation
:app:assembleDebug(512 tasks)git diff --checkReal-device latency validation is still required.