Fix card monitor restart after polling error - #50
Merged
Conversation
Clear monitor state immediately on error termination so same-options startCardMonitor starts a new loop instead of no-oping while async error delivery is still pending. Co-authored-by: Cursor <cursoragent@cursor.com>
Only deliver onCardMonitorError when the post-termination generation is still current, so a newer start/stop does not receive the previous session's failure. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
startCardMonitorwith the same options starts a new loop instead of no-oping while asynconCardMonitorErrordelivery is still pending (Android + iOS).Test plan
pnpm testonCardMonitorErrorstartCardMonitorwith the same options after that failure; confirm a new monitor loop runs (presence/removal events resume)stopCardMonitor/autoStopAfterMsstill emit no errorMade with Cursor