Closed
Conversation
osfameron
reviewed
Jul 2, 2025
osfameron
reviewed
Jul 2, 2025
osfameron
requested changes
Jul 2, 2025
Collaborator
osfameron
left a comment
osfameron
left a comment
There was a problem hiding this comment.
need to replace the UI bundle when that's merged in
Collaborator
|
I think the steps to get this merged in are:
I think 1) is important because we don't want the complexity of extensions added just "on the off chance", but because they have a recognized benefit to the team. |
RayOffiah
force-pushed
the
adding-anywhere-footnote
branch
4 times, most recently
from
5b44440 to
6fb9dc8
Compare
RayOffiah
force-pushed
the
adding-anywhere-footnote
branch
from
b171378 to
020bf30
Compare
RayOffiah
force-pushed
the
adding-anywhere-footnote
branch
from
9ee9632 to
28af089
Compare
osfameron
reviewed
Jul 18, 2025
|
|
||
| |1 | ||
| |Product Aafnote:first-block[This is the first footnote] | ||
| |High-quality widget with advanced features{empty}afnote:first-block[This is the second] |
Collaborator
There was a problem hiding this comment.
I like the {empty} to disambiguate, we should have that throughout to recommend that as best practice.
RayOffiah
force-pushed
the
adding-anywhere-footnote
branch
2 times, most recently
from
6de7cab to
3fb1b0a
Compare
RayOffiah
force-pushed
the
adding-anywhere-footnote
branch
2 times, most recently
from
82c3e73 to
abef54f
Compare
Add `asciidoctor-anywhere-footnote` to Antora playbook and update UI bundle to prod-213 Add `asciidoctor-anywhere-footnote` to Antora playbook and update UI bundle path for local build Add `anywhere-footnotes` example and link to navigation Upgrade `asciidoctor-anywhere-footnote` to ~1.2.7 and update dependencies in `package-lock.json`. Upgrade `asciidoctor-anywhere-footnote` to ~1.2.2 and update dependencies in `package-lock.json`. Upgrade `asciidoctor-anywhere-footnote` to ~1.2.1 and update dependencies in `package-lock.json`. Upgrade `asciidoctor-anywhere-footnote` to ~1.2.0 and update dependencies in `package-lock.json`. Add `asciidoctor-anywhere-footnote` to Antora preview playbook Upgrade `asciidoctor-anywhere-footnote` to ~1.1.9 and update dependencies in `package-lock.json`. Updated to include the correct URL for the UI bundle. The PR for the new UI bundle (couchbase/docs-ui#193) should be reviewed first so we know the number of the bundle. Upgrade `asciidoctor-anywhere-footnote` to ~1.1.8 and update dependencies in `package-lock.json`. Updating package.json Adding the anywhere-footnote extension
Test is failing due to ID being randomly auto-generated. Will see if that feature can be suppressed, as it's desirable for static site generator to be deterministic.
Update footnote markers in `anywhere-footnotes` example to remove brackets and improve readability. Update UI bundle URL to `adding-anywhere-footnote-13` in Antora preview playbook Upgrade `asciidoctor-anywhere-footnote` to ~1.3.2 and update dependencies in `package-lock.json`. Upgrade `asciidoctor-anywhere-footnote` to ~1.3.1, update footnote structure in `anywhere-footnotes` example, and remove the unused `randomstring` dependency Add `refid` attributes to footnotes in `anywhere-footnotes` example. This is to ensure that the unit tests don't need to worry about the random strings that are usually applied to the footnote references.
…for cleaner HTML structure.
RayOffiah
force-pushed
the
adding-anywhere-footnote
branch
from
abef54f to
a4bfb35
Compare
Contributor
Author
|
Right. Abandoning this as an idea. There are better ways to do it that are more reliable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for footnotes that can appear anywhere on the page.