PYCO-98: Update Error Handling#15
Merged
Merged
Conversation
Changes ------- * Raise `AnalyticsError` if SDK receives HTTP 500 status code * Raise `AnalyticsError` if `start_query()` response is missing `requestID` or `handle`
Contributor
There was a problem hiding this comment.
Pull request overview
Updates protocol-level error handling to ensure the client surfaces consistent AnalyticsError exceptions for certain server-side failures and malformed start_query() responses.
Changes:
- Map HTTP 500 responses to
AnalyticsErrorviaErrorMapper.maybe_get_error_from_status_code. - Raise
AnalyticsError(instead ofQueryNotFoundError) whenstart_query()responses are missingrequestIDand/orhandle. - Apply the missing-field handling consistently across both blocking and async query-handle implementations.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| couchbase_analytics/protocol/query_handle.py | Consolidates missing requestID/handle checks and raises AnalyticsError with a combined missing-fields message. |
| couchbase_analytics/protocol/errors.py | Adds HTTP 500 handling to raise AnalyticsError from status-code checks. |
| acouchbase_analytics/protocol/query_handle.py | Mirrors the blocking implementation’s missing-field handling for async query handles. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
DemetrisChr
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
AnalyticsErrorif SDK receives HTTP 500 status codeAnalyticsErrorifstart_query()response is missingrequestIDorhandle