JSCO-74: Add per-request DNS record selection and RFC-aligned connection-error retry handling#23
Merged
Conversation
…ion-error retry handling Changes -------- * Added per-request random A/AAAA record selection; requests now connect to the resolved IP while keeping the hostname for TLS SNI and the Host header. * Replaced the connection-error deny-list with an allowlist that retries only DNS and TCP-dial failures. * Fixed TLS handshake/certificate errors being retried; they now fail fast * Wrapped DNS-resolution failures (EAI_AGAIN, ENOTFOUND, empty result) as retriable connection errors. * Changed request log lines to show the resolved connect IP instead of the hostname. * Added unit tests for host selection, DNS-failure wrapping, and retry classification.
Matt-Woz
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes