refactor(ui): migrate Button to Base UI Button primitive - #828
Open
pasqualevitiello wants to merge 4 commits into
Open
refactor(ui): migrate Button to Base UI Button primitive#828pasqualevitiello wants to merge 4 commits into
pasqualevitiello wants to merge 4 commits into
Conversation
Replace the custom useRender wrapper with @base-ui/react/button and style links via buttonVariants instead of Button render={<Link />}, matching shadcn guidance. Disabled styles use data-disabled so focusableWhenDisabled loading states stay consistent.
Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Update Button docs, changelog, radix migration, and agent skills so links use buttonVariants instead of Button render. Co-authored-by: Cursor <cursoragent@cursor.com>
Drop the React.MouseEvent annotation so the handler accepts BaseUIEvent from @base-ui/react/button. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useRenderButton wrapper with@base-ui/react/button, keepingbuttonVariants, sizes/variants, and theloading+ Spinner behavior<Button render={<Link|a />}>for links; style plainLink/awithbuttonVariantsinstead (shadcn-aligned)data-disabledsofocusableWhenDisabledloading buttons keep correct visuals; update call sites across ui, www, shared, calcom examples, and particlesTest plan
bun test packages/ui/test/components/button.test.tsxMade with Cursor