rename metric label values for fetched-data limit rejections#7517
Open
SungJin1212 wants to merge 1 commit into
Open
rename metric label values for fetched-data limit rejections#7517SungJin1212 wants to merge 1 commit into
SungJin1212 wants to merge 1 commit into
Conversation
dosubot
Bot
added
the
type/observability
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
SungJin1212
force-pushed
the
Rename-reason-label-values
branch
from
ae41fd9 to
081be7e
Compare
friedrichg
requested changes
May 14, 2026
Member
friedrichg
left a comment
friedrichg
left a comment
There was a problem hiding this comment.
This will break people's dashboards and alerts for no immediate gain.
Can you clarify why is this necessary?
| reasonResourceExhausted = "resource_exhausted" | ||
| reasonTimeRangeExceeded = "time_range_exceeded" | ||
| reasonResponseSizeExceeded = "response_size_exceeded" | ||
| reasonTooManySamples = "too_many_samples" |
Member
There was a problem hiding this comment.
shouldn't this also be fetch_too_many_samples_exceeded?
Member
Author
There was a problem hiding this comment.
This might break existing dashboards and alerts. However, I realized that the existing values cannot clearly explain why the query is being rejected (these are label values of the reason).
I think the too_many_samples is clear enough to explain why the query is rejected.
The fetch_too_many_samples_exceeded is clearer, but I'd prefer to keep the changes to a minimum.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the naming of
cortex_rejected_queries_totalmetric label values to make them more descriptive and consistent.series_fetched,chunks_fetched,chunk_bytes_fetched,data_bytes_fetched.fetched_series_exceeded,fetched_chunks_exceeded,fetched_chunk_bytes_exceeded,fetched_data_bytes_exceeded.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags