security: fix stored XSS in alertmanager and storegateway status pages#7512
Merged
danielblando merged 3 commits intoMay 12, 2026
Conversation
Replace text/template with html/template in alertmanager_http.go and gateway_http.go to auto-escape HTML special characters. This prevents stored XSS via crafted gossip member names rendered on status pages. The html/template package has an identical API to text/template but automatically escapes HTML, JS, and URI contexts. Add TestStatusHandler_HTMLEscaping to verify XSS payloads are escaped. Fixes #22 Signed-off-by: Daniel Blando <ddeluigg@amazon.com>
danielblando
force-pushed
the
fix/xss-text-template-to-html-template
branch
from
284c0d3 to
ec12938
Compare
friedrichg
approved these changes
May 12, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes a stored XSS vulnerability in the Alertmanager and Store Gateway HTTP status pages by replacing
text/templatewithhtml/template.Fix
Replace
text/templatewithhtml/templatein:pkg/alertmanager/alertmanager_http.gopkg/storegateway/gateway_http.gohtml/templateautomatically escapes values in HTML context, preventing script injection.Testing
Added
pkg/alertmanager/alertmanager_http_test.gotest that verifies HTML-special characters in tenant IDs are properly escaped in the rendered output.