Skip to content

fix(ha): Fix flaky TestWatchPrefixNilPanicWithMemberlist #7493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
friedrichg merged 1 commit into from
May 8, 2026
+7 −1
Merged

fix(ha): Fix flaky TestWatchPrefixNilPanicWithMemberlist #7493

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion pkg/ha/ha_tracker_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,10 +265,16 @@ func TestWatchPrefixNilPanicWithMemberlist(t *testing.T) {
replica := "replica0"
key := userID + "/" + cluster

// Give the WatchPrefix goroutine in loop() time to register its watcher
// channel in the memberlist KV before we write. Without this, the CAS
// notification can fire before the watcher is registered, causing the
// key to never appear in the elected cache.
time.Sleep(100 * time.Millisecond)

now := time.Now()
require.NoError(t, tracker.CheckReplica(ctx, userID, cluster, replica, now))

test.Poll(t, 3*time.Second, nil, func() any {
test.Poll(t, 5*time.Second, nil, func() any {
tracker.electedLock.RLock()
defer tracker.electedLock.RUnlock()
if _, ok := tracker.elected[key]; !ok {
Expand Down
Loading