Skip to content

fix(ring): Fix flaky TestMinimizeSpreadTokenGenerator #7484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yeya24 merged 1 commit into from
May 7, 2026
+2 −2
Merged

fix(ring): Fix flaky TestMinimizeSpreadTokenGenerator #7484

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/ring/token_generator_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ func TestMinimizeSpreadTokenGenerator(t *testing.T) {
// Should Generate tokens based on the ring state
for i := range 50 {
generateTokensForIngesters(t, rindDesc, fmt.Sprintf("minimize-%v", i), zones, minimizeTokenGenerator, dups)
assertDistancePerIngester(t, rindDesc, 0.01)
assertDistancePerIngester(t, rindDesc, 0.02)
}
require.Equal(t, mTokenGenerator.called, len(zones))

Expand All @@ -103,7 +103,7 @@ func TestMinimizeSpreadTokenGenerator(t *testing.T) {
rindDesc.AddIngester("partial", "partial", zones[0], rTokens, ACTIVE, time.Now())
nTokens := minimizeTokenGenerator.GenerateTokens(rindDesc, "partial", zones[0], 256, true)
rindDesc.AddIngester("partial", "partial", zones[0], append(rTokens, nTokens...), ACTIVE, time.Now())
assertDistancePerIngester(t, rindDesc, 0.01)
assertDistancePerIngester(t, rindDesc, 0.02)

mTokenGenerator.called = 0
// Should fallback to random generator when more than 1 ingester does not have tokens and force flag is set
Expand Down
Loading