Skip to content

test(accounts): assert removed-account secrets are pruned from the state file #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iceteaSA wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(accounts): assert removed-account secrets are pruned from the state file #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/opencode/src/tests/accounts-store.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,15 @@ describe('mutateAccounts (authoritative structural edits)', () => {
// proving the deletion was authoritative, not just an in-memory filter.
const cfg = JSON.parse(readFileSync(cfgPath, 'utf8'))
expect(cfg.accounts.map((a: { id: string }) => a.id)).toEqual(['a', 'c'])

// The state file is rebuilt from the authoritative account set, so the
// removed account's per-account secrets must not linger at rest — a stale
// access/refresh token for a deleted account is a credential leak.
const stateRaw = readFileSync(statePath, 'utf8')
const state = JSON.parse(stateRaw)
expect(Object.keys(state.accounts ?? {}).sort()).toEqual(['a', 'c'])
expect(stateRaw).not.toContain('acc-b')
expect(stateRaw).not.toContain('ref-b')
})

it('reordering persists (union-merge would have ignored it)', async () => {
Expand Down