Refactor RewriteConstants, remove deprecated btf flush cache - #6
Open
vishnukumarkvs wants to merge 1 commit into
Open
Refactor RewriteConstants, remove deprecated btf flush cache#6vishnukumarkvs wants to merge 1 commit into
vishnukumarkvs wants to merge 1 commit into
Conversation
Author
|
Need it for coroot/coroot-node-agent#364 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When bumping cilium to v1.20.0 version in coroot-node-agent, it also bumps cilium/ebpf package to v0.22.0. With the bumps, the build fails because coroot pyroscope uses same packages underneath and it breaks due to incompatible code
This MR introduces cilium/ebpf v0.22.0 complaint changes
Two changes are made
btf cache flush
This is related to ebpf_python profiling. btf.FlushKernelSpec() calls are removed now because Cache became explicit in latest versions.
RewriteConstants refactor
RewriteConstants → Variables[...].Set() — Cilium's eBPF library removed the old helper method for writing config values into the BPF program before loading it. Same underlying mechanism, just called directly.