Skip to content

fix(arena sunk): removing redundant print statement to fix double printout of command output #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonas-werner wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(arena sunk): removing redundant print statement to fix double printout of command output #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions arena/notebooks/arena_sunk_cluster_walkthrough_benchmarks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,21 +84,21 @@ def _(mo):
@app.cell
def _(shell):
# Slurm cluster info:
print(shell("sinfo"))
shell("sinfo")
return


@app.cell
def _(shell):
# Slurm user info:
print(shell("sacctmgr show users"))
shell("sacctmgr show users")
return


@app.cell
def _(shell):
# Slurm accounting info:
print(shell("sacctmgr show associations format=User,Account,Partition,QOS"))
shell("sacctmgr show associations format=User,Account,Partition,QOS")
return


Expand All @@ -113,7 +113,7 @@ def _(mo):
@app.cell
def _(shell):
# Node info
print(shell("scontrol show nodes"))
shell("scontrol show nodes")
return


Expand All @@ -127,7 +127,7 @@ def _(mo):

@app.cell
def _(shell):
print(shell("scontrol show partition"))
shell("scontrol show partition")
return


Expand Down Expand Up @@ -184,21 +184,21 @@ def _(num_nodes, shell, submit_btn):
if submit_btn.value:
cmd = f"cd /mnt/data/arena/benchmarks/nccl/nccl-tests/slurm && sbatch -N {num_nodes.value} nccl-test-distributed-h100-64.slurm"
print(f"Running: sbatch -N {num_nodes.value} ...")
print(shell(cmd))
shell(cmd)
else:
print("Click 'Submit NCCL Test Job' to run the benchmark")
return


@app.cell
def _(shell):
print(shell("squeue"))
shell("squeue")
return


@app.cell
def _(shell):
print(shell("ls /mnt/data/arena/benchmarks/nccl/nccl-tests/slurm/*.out"))
shell("ls /mnt/data/arena/benchmarks/nccl/nccl-tests/slurm/*.out")
return


Expand Down