Skip to content

tests: ls: add test for fix expected output for single-row across layout#213

Open
sylvestre wants to merge 1 commit intocoreutils:masterfrom
sylvestre:ls-across-one-row
Open

tests: ls: add test for fix expected output for single-row across layout#213
sylvestre wants to merge 1 commit intocoreutils:masterfrom
sylvestre:ls-across-one-row

Conversation

@sylvestre
Copy link
Contributor

@pixelb
Copy link
Member

pixelb commented Mar 10, 2026

I don't understand the test. Why set the width to 96 when only 79 cols output.
Was this not an off by one issue?
BTW it looks like GNU may have an off by one issue, as I'm surprised the following are not the same:

$ src/ls -w80 ~/t/subdir/; ruler
code  Desktop  Documents  Downloads  Music  Pictures  Public  Templates  Videos
123456789¹123456789²123456789³123456789⁴123456789⁵123456789⁶123456789⁷123456789⁸

$ src/ls -w79 ~/t/subdir/; ruler
code	 Documents  Music     Public	 Videos
Desktop  Downloads  Pictures  Templates
123456789¹123456789²123456789³123456789⁴123456789⁵123456789⁶123456789⁷123456789⁸

@pixelb pixelb closed this Mar 10, 2026
@pixelb pixelb reopened this Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants