Differentiate between null and empty array for Stores field to prevent unwanted inheritance#2941
Draft
Differentiate between null and empty array for Stores field to prevent unwanted inheritance#2941
Conversation
- Modified Multiselect::preGetData to preserve null values - Added isEmpty method to treat null as empty but not [] - Updated all callers to handle null with ?? [] operator Co-authored-by: dpfaffenbauer <5981845+dpfaffenbauer@users.noreply.github.com>
- Improve isEmpty docstring to specify array|null type - Remove redundant double sprintf in CategoryController Co-authored-by: dpfaffenbauer <5981845+dpfaffenbauer@users.noreply.github.com>
|
Copilot
AI
changed the title
[WIP] Implement differentiation between empty and null for Stores field
Differentiate between null and empty array for Stores field to prevent unwanted inheritance
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



When a variant's stores are explicitly cleared (all removed), Pimcore's inheritance incorrectly pulls stores from the parent product. This happens because
null(not set) and[](explicitly empty) were treated identically.Changes
Multiselect::preGetData: Removed auto-conversion ofnull→[], preserving inheritance semanticsMultiselect::isEmpty: Added override returningtrueonly fornull, not[]?? []to 3 call sites (ProductController, CategoryController, ProductContext)Semantics
Applies to all Multiselect-based fields (Stores, Countries, Currencies, Carriers, PaymentProviders).
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.