Add unsupported query feature exception#488
Merged
abdessamad-abdoun merged 1 commit intoJul 16, 2026
Merged
Conversation
|
Test Results 435 files 435 suites 30s ⏱️ Results for commit 47988d4. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Pull request overview
This PR introduces a dedicated UnsupportedQueryFeatureException to consistently report syntactically valid SPARQL features that are not yet implemented in the “next” pipeline, and updates the bridge/runtime code paths and tests to use this typed exception instead of UnsupportedOperationException.
Changes:
- Add
UnsupportedQueryFeatureExceptionto the next query API exception set. - Replace several bridge-level
UnsupportedOperationExceptionthrows withUnsupportedQueryFeatureException(WHERE compilation, filter conversion, query builder clause rejection). - Update/extend bridge tests to assert the new exception type is raised for unsupported-but-valid features.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/fr/inria/corese/core/next/query/api/exception/UnsupportedQueryFeatureException.java | Adds the new dedicated exception type for unsupported query features. |
| src/main/java/fr/inria/corese/core/next/query/impl/sparql/bridge/WhereCompiler.java | Throws UnsupportedQueryFeatureException for unsupported WHERE pattern kinds. |
| src/main/java/fr/inria/corese/core/next/query/impl/sparql/bridge/SparqlAstToExpression.java | Throws UnsupportedQueryFeatureException for unsupported constraint/filter conversions (e.g., EXISTS). |
| src/main/java/fr/inria/corese/core/next/query/impl/sparql/bridge/CoreseAstQueryBuilder.java | Standardizes unsupported-feature failures in query building to use the new exception type. |
| src/test/java/fr/inria/corese/core/next/query/impl/sparql/bridge/WhereCompilerTest.java | Adds coverage asserting unsupported WHERE patterns fail with the typed exception. |
| src/test/java/fr/inria/corese/core/next/query/impl/sparql/bridge/SparqlAstToExpressionTest.java | Adds coverage asserting EXISTS filter conversion fails with the typed exception. |
| src/test/java/fr/inria/corese/core/next/query/impl/sparql/bridge/CoreseAstQueryBuilderDescribeTest.java | Updates tests to expect UnsupportedQueryFeatureException for unsupported DESCRIBE clauses. |
| src/test/java/fr/inria/corese/core/next/query/impl/sparql/bridge/CoreseAstQueryBuilderConstructTest.java | Updates tests to expect UnsupportedQueryFeatureException for unsupported CONSTRUCT clauses. |
| src/test/java/fr/inria/corese/core/next/query/impl/sparql/bridge/CoreseAstQueryBuilderAskTest.java | Updates tests to expect UnsupportedQueryFeatureException for unsupported ASK clauses. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
remiceres
force-pushed
the
feature/487-unsupported-query-feature-exception
branch
from
July 16, 2026 08:03
13516d7 to
47988d4
Compare
|
abdessamad-abdoun
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #487.
This PR adds a dedicated exception for SPARQL features that are valid but not supported yet by the next pipeline.
It replaces a few bridge-level UnsupportedOperationException cases with UnsupportedQueryFeatureException and updates the related tests.