butane/fcos: remove duplicate cex translation registration - #2297
butane/fcos: remove duplicate cex translation registration#2297vishnu2ko5 wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📜 Recent review details🧰 Additional context used📓 Path-based instructions (1)**/*.go📄 CodeRabbit inference engine (AGENTS.md)
Files:
🔇 Additional comments (3)
📝 WalkthroughWalkthroughThe FCOS v1.6, v1.7, and v1.8 experimental translators now translate the complete boot-device CEX structure instead of only its ChangesCEX translation
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This is a small, localized cleanup of duplicate CEX translation registration across three supported specs, with no actionable merge-blocking risk remaining beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Removes a redundant translation merge call in
translateBootDeviceLuksCexthat was causing duplicate translation registrations for theenabledfield.The function
translateBootDeviceLuksCexwas previously calling bothtranslate.Prefixedandtranslate.MergePfor the exact sameenabledfield inBootDeviceLuks.Cex. This PR updates the logic to simply translate the entireCexstruct usingtranslate.Prefixed, which is sufficient and correctly maintains theTranslationSet.This fix is applied across all experimental and stable FCOS Butane specs that support CEX (
v1_6,v1_7, andv1_8_exp), preventing incorrect path tracking and duplicate entries for CEX-enabled LUKS configurations.