add: db.rs for inserting and querying profiles#4
Draft
bhavaygoel wants to merge 1 commit intomasterfrom
Draft
Conversation
GetPsyched
requested changes
Jun 27, 2024
| @@ -1,2 +1,3 @@ | |||
| /target | |||
| /result | |||
| .env No newline at end of file | |||
Member
There was a problem hiding this comment.
Every file needs to end with a line break.
Suggested change
| .env | |
| .env | |
| select_all_users().await?; | ||
|
|
||
| Ok(()) | ||
| } No newline at end of file |
Member
There was a problem hiding this comment.
Same here
Suggested change
| } | |
| } | |
|
|
||
| #[tokio::main] | ||
| async fn main() { | ||
| if let Err(e) = db::run_db_operations().await { |
Member
There was a problem hiding this comment.
Abstract that out to a variable; conciseness is good but this harms readability.
| use std::env; | ||
|
|
||
| pub async fn insert_user(name: &str, age: i32) -> Result<(), Error> { | ||
| dotenv().ok(); |
Member
There was a problem hiding this comment.
Haven't explored this yet but there's probably a better place for this? I can't imagine doing this in every single function.
|
|
||
| pub async fn insert_user(name: &str, age: i32) -> Result<(), Error> { | ||
| dotenv().ok(); | ||
| let database_url = env::var("DATABASE_URL").expect("DATABASE_URL must be set"); |
Member
There was a problem hiding this comment.
This too, probably should be attached to some global/pseudo-global context that is available readily.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i assumed the dummy table as: