feat: add deviceplugin, webhook#2
Merged
Merged
Conversation
This adds full support for scheduling and running the quantum workload. We do this by allowing addition of custom resource types to fluxion, and in this case, the qpu. These are countable resources that can be thus returned "YES" by a node-level device plugin. I am choosing this approach over DRA for the time being because I want the user to be able to define fluxion type resources in the resource spec and not have to define DeviceClass or ResourceClaim that I still find annoying and clunky. To handle the backend, we add an envar in a webhook before pod creation to expect the envar via an annotation, and that is added in prebind. This was just tested with a quantum pod and vanilla podgroup and works great! Super cool. Signed-off-by: vsoch <vsoch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds full support for scheduling and running the quantum workload. We do this by allowing addition of custom resource types to fluxion, and in this case, the qpu. These are countable resources that can be thus returned "YES" by a node-level device plugin. I am choosing this approach over DRA for the time being because I want the user to be able to define fluxion type resources in the resource spec and not have to define DeviceClass or ResourceClaim that I still find annoying and clunky. To handle the backend, we add an envar in a webhook before pod creation to expect the envar via an annotation, and that is added in prebind. This was just tested with a quantum pod and vanilla podgroup and works great! Super cool.