fix: stop prefixing markdown chunks with the string undefined - #13149
Open
tonycoder-hub wants to merge 1 commit into
Open
fix: stop prefixing markdown chunks with the string undefined#13149tonycoder-hub wants to merge 1 commit into
tonycoder-hub wants to merge 1 commit into
Conversation
…ned" markdownChunker recurses one header level at a time and prepends each section's header to every chunk it produces. When a section has no header, findHeader returns undefined and the template literal interpolated it as the literal text "undefined", so headerless docs were indexed with up to five bogus "undefined" lines at the top of every chunk. Only prepend the header when the section actually has one.
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
markdownChunker prepends each section header to every chunk. When a section has no header, findHeader returns undefined and the template literal interpolated it as the literal text "undefined". Headerless docs were indexed with up to five bogus undefined lines at the top of every chunk (used by @docs indexing).
Only prepend the header when the section actually has one.
Tests: cd core && npx vitest run indexing/chunk/markdown.vitest.ts — 3 passed. Distinct from #13140-#13148.