Skip to content

fix(core): reload config after create_rule_block so the new rule applies immediately #12920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
houssemzaier wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −0
Open

fix(core): reload config after create_rule_block so the new rule applies immediately #12920

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions core/core.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import { fetchModels } from "./llm/fetchModels";
import Ollama from "./llm/llms/Ollama";
import { EditAggregator } from "./nextEdit/context/aggregateEdits";
import { createNewPromptFileV2 } from "./promptFiles/createNewPromptFile";
import { BuiltInToolNames } from "./tools/builtIn";
import { callTool } from "./tools/callTool";
import { ChatDescriber } from "./util/chatDescriber";
import { compactConversation } from "./util/conversationCompaction";
Expand Down Expand Up @@ -1185,6 +1186,18 @@ export class Core {
codeBaseIndexer: this.codeBaseIndexer,
});

// Hot-reload config when a rule is created via the create_rule_block tool,
// since ide.writeFile() does not trigger VS Code workspace file events.
if (
toolCall.function.name === BuiltInToolNames.CreateRuleBlock &&
!result.errorMessage
) {
walkDirCache.invalidate();
await this.configHandler.reloadConfig(
"Rule created via create_rule_block tool",
);
}

return result;
}

Expand Down
Loading