Skip to content

a11y: make message history and action buttons accessible to screen readers #12901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
drewpoling2 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −2
Open

a11y: make message history and action buttons accessible to screen readers #12901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions gui/src/components/gui/HeaderButtonWithToolTip.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ interface HeaderButtonWithToolTipProps {
hoverBackgroundColor?: string;
tooltipPlacement?: PlacesType;
testId?: string;
ariaLabel?: string;
}

const HeaderButtonWithToolTip = React.forwardRef<
Expand All @@ -41,6 +42,7 @@ const HeaderButtonWithToolTip = React.forwardRef<
style={props.style}
ref={ref}
tabIndex={props.tabIndex}
aria-label={props.ariaLabel ?? props.text}
>
{props.children}
</HeaderButton>
Expand Down
8 changes: 6 additions & 2 deletions gui/src/pages/gui/Chat.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,9 @@ import { ToolCallDiv } from "./ToolCallDiv";
import { useStore } from "react-redux";
import FeedbackDialog from "../../components/dialogs/FeedbackDialog";

import { DeprecationBanner } from "../../components/DeprecationBanner";
import { FatalErrorIndicator } from "../../components/config/FatalErrorNotice";
import { DeprecationBanner } from "../../components/DeprecationBanner";
import InlineErrorMessage from "../../components/mainInput/InlineErrorMessage";
import { resolveEditorContent } from "../../components/mainInput/TipTapEditor/utils/resolveEditorContent";
import { setDialogMessage, setShowDialog } from "../../redux/slices/uiSlice";
import { RootState } from "../../redux/store";
import { cancelStream } from "../../redux/thunks/cancelStream";
Expand Down Expand Up @@ -386,6 +385,9 @@ export function Chat() {

<StepsDiv
ref={stepsDivRef}
role="log"
aria-label="Message history"
aria-live="polite"
className={`pt-[8px] ${showScrollbar ? "thin-scrollbar" : "no-scrollbar"} ${history.length > 0 ? "min-h-0 flex-1 overflow-y-scroll" : "shrink-0"}`}
>
<DeprecationBanner dismissable={true} />
Expand All @@ -395,6 +397,8 @@ export function Chat() {
.map((item, index: number) => (
<div
key={item.message.id}
tabIndex={0}
aria-label={`${item.message.role === "user" ? "You" : "Assistant"}, message ${index + 1}`}
style={{
minHeight: index === history.length - 1 ? "200px" : 0,
}}
Expand Down
Loading