fix(cli): report missing npm during install#12268
Open
cyphercodes wants to merge 1 commit intocontinuedev:mainfrom
Open
fix(cli): report missing npm during install#12268cyphercodes wants to merge 1 commit intocontinuedev:mainfrom
cyphercodes wants to merge 1 commit intocontinuedev:mainfrom
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #12192.
Adds explicit npm validation before the CLI installer uses
npm config get prefix. If Node.js is present but npm is missing or its global prefix cannot be read / resolves to an unsafe value, the installer now prints a targetedNode.js was found but npm is missing or misconfigurederror instead of only exiting through the generic cleanup message.AI Code Review
@continue-reviewChecklist
Screen recording or screenshot
Not applicable; this is installer error handling.
Tests
bash -n extensions/cli/scripts/install.shgit diff --checksetup_npm_pathwith nonpmavailable: verified it exits non-zero with the targeted npm diagnostic.v22.22.2and nonpmavailable: verified it exits non-zero after reporting the targeted npm diagnostic.