Conversation
when chathistoryservice is disabled in subagent, manually update the last tool state with output and status
explorer and code reviewer
sestinj
left a comment
There was a problem hiding this comment.
For now, I think we should still make sure that we have a way to disable sub-agents, even if we have them on by default, just in case we need to roll something back. e.g. CN_DISABLE_SUBAGENTS=1.
| Your output should be concise and actionable, starting with a brief summary of what you found and listing the key files/paths, functions, symbols, and important relationships or flows between them in plain language. If you cannot find something, describe what you searched for, where you looked, and suggest next places or strategies to investigate.`, | ||
| }; | ||
|
|
||
| export const CODE_REVIEWER_SUBAGENT: BuiltInSubagent = { |
There was a problem hiding this comment.
I feel the code-reviewer agent might be a bit too specific. I wonder if we could instead do a task agent that can be given any general task, such as simple refactors. I find that Claude Code's Task subagent is used very frequently, but I don't often see it using sub-agents for review, so I worry that Claude just wouldn't use this subagent very often
There was a problem hiding this comment.
1 issue found across 4 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="extensions/cli/src/tools/subagent.test.ts">
<violation number="1" location="extensions/cli/src/tools/subagent.test.ts:6">
P2: Mock path no longer matches the imported module path, so getAgentNames/getSubagent won’t be mocked and vi.mocked(...).mockReturnValue may fail or run real logic.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| import { serviceContainer } from "../services/ServiceContainer.js"; | ||
| import { executeSubAgent } from "../subagent/executor.js"; | ||
| import { getAgentNames, getSubagent } from "../subagent/get-agents.js"; | ||
| import { getAgentNames, getSubagent } from "../subagent/getAgents.js"; |
There was a problem hiding this comment.
P2: Mock path no longer matches the imported module path, so getAgentNames/getSubagent won’t be mocked and vi.mocked(...).mockReturnValue may fail or run real logic.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At extensions/cli/src/tools/subagent.test.ts, line 6:
<comment>Mock path no longer matches the imported module path, so getAgentNames/getSubagent won’t be mocked and vi.mocked(...).mockReturnValue may fail or run real logic.</comment>
<file context>
@@ -3,7 +3,7 @@ import { beforeEach, describe, expect, it, vi } from "vitest";
import { serviceContainer } from "../services/ServiceContainer.js";
import { executeSubAgent } from "../subagent/executor.js";
-import { getAgentNames, getSubagent } from "../subagent/get-agents.js";
+import { getAgentNames, getSubagent } from "../subagent/getAgents.js";
import { subagentTool } from "./subagent.js";
</file context>
Description
Add 2 builtin subagents: navigator and code reviewer.
AI Code Review
@continue-reviewChecklist
Screen recording or screenshot
[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]
Tests
[ What tests were added or updated to ensure the changes work as expected? ]
Continue Tasks: ❌ 7 failed — View all
Summary by cubic
Adds built-in Navigator and Generalist subagents (auto-added when using Anthropic with a local API key) and enables the subagent tool by default. Fixes tool call results in subagents and prevents nested subagent execution.
New Features
Bug Fixes
Written for commit af13df6. Summary will update on new commits.