Skip to content

Enhance error handling and messaging across multiple files. #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harshithad0703 merged 17 commits into from
Nov 7, 2025
Merged

Enhance error handling and messaging across multiple files. #128

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
fc4eae2
Enhance error handling and messaging across multiple files.
reeshika-h Aug 31, 2025
3e51f35
Refactor error handling in asset and entry processing to use custom e…
reeshika-h Sep 2, 2025
a080634
Refactor error handling to utilize custom exceptions and improve erro…
reeshika-h Sep 3, 2025
ba6fe9a
Refactor ContentstackException usage to streamline error handling acr…
reeshika-h Oct 31, 2025
0f99e20
Tests: Added the Unit test cases and Fixed the existing failing APi T…
cs-raj Nov 6, 2025
84917b0
Test cases update
cs-raj Nov 6, 2025
f12f881
Workflow for unit test cases
cs-raj Nov 6, 2025
140a99f
Updated only for test execution
cs-raj Nov 6, 2025
08ae260
Test workflow updated
cs-raj Nov 6, 2025
d532971
.NET Version updated
cs-raj Nov 6, 2025
156192b
Fixed the unit test cases
cs-raj Nov 6, 2025
607f914
version bump
reeshika-h Nov 7, 2025
ea636b3
Merge branch 'development' into fix/DX-3455-error-message-improve
reeshika-h Nov 7, 2025
87592d7
version bump
reeshika-h Nov 7, 2025
374c9ce
Added unit test proj file
cs-raj Nov 7, 2025
1cb4698
Merge remote-tracking branch 'origin/tests/DX-3676' into fix/DX-3455-…
reeshika-h Nov 7, 2025
998c10b
fix tests
reeshika-h Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Contentstack.Core.Tests/ContentTypeTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
using System;
using Xunit;
using Contentstack.Core.Models;
using Contentstack.Core.Internals;
using System.Threading.Tasks;
using System.Collections.Generic;
using Newtonsoft.Json.Linq;
Expand Down Expand Up @@ -143,7 +144,7 @@ public async Task FetchGlobalFieldSchema_NullParameters_Succeeds()
[Fact]
public void GlobalField_EmptyUid_Throws()
{
Assert.Throws<ArgumentNullException>(() => {
Assert.Throws<GlobalFieldException>(() => {
GlobalField globalField = client.GlobalField("");
});
}
Expand Down
7 changes: 3 additions & 4 deletions Contentstack.Core/ContentstackClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ public ContentstackClient(IOptions<ContentstackOptions> options)
}
else
{
throw new InvalidOperationException("Add PreviewToken or ManagementToken in LivePreviewConfig");
throw new InvalidOperationException(ErrorMessages.LivePreviewTokenMissing);
}
}
this.SerializerSettings.DateParseHandling = DateParseHandling.None;
Expand Down Expand Up @@ -239,10 +239,9 @@ internal static ContentstackException GetContentstackError(Exception ex)
errorMessage = ex.Message;
}

contentstackError = new ContentstackException()
contentstackError = new ContentstackException(errorMessage)
{
ErrorCode = errorCode,
ErrorMessage = errorMessage,
StatusCode = statusCode,
Errors = errors
};
Expand Down Expand Up @@ -372,7 +371,7 @@ private async Task<JObject> GetLivePreviewData()
}
else
{
throw new InvalidOperationException("Either ManagementToken or PreviewToken is required in LivePreviewConfig");
throw new InvalidOperationException(ErrorMessages.LivePreviewTokenMissing);
}

if (!string.IsNullOrEmpty(this.LivePreviewConfig.ReleaseId))
Expand Down
2 changes: 1 addition & 1 deletion Contentstack.Core/Internals/AssetJsonConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public override Asset ReadJson(JsonReader reader, Type objectType, Asset existin

public override void WriteJson(JsonWriter writer, Asset value, JsonSerializer serializer)
{
throw new NotImplementedException();
throw AssetException.CreateForJsonConversionError();
}
}
}
94 changes: 0 additions & 94 deletions Contentstack.Core/Internals/ContentStackError.cs
View file
Open in desktop

This file was deleted.

88 changes: 44 additions & 44 deletions Contentstack.Core/Internals/ContentstackConvert.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@ public static Int32 ToInt32(object input)
{
output = Convert.ToInt32(input);
}
catch (Exception e)
{
if (e.Source != null)
{
Console.WriteLine("IOException source: {0}", e.Source);
}
catch (Exception e)
{
if (e.Source != null)
{
Console.WriteLine(ErrorMessages.FormatExceptionDetails(e));
}
}

return output;
Expand All @@ -34,12 +34,12 @@ public static bool ToBoolean(object input)
{
output = Convert.ToBoolean(input);
}
catch (Exception e)
{
if (e.Source != null)
{
Console.WriteLine("IOException source: {0}", e.Source);
}
catch (Exception e)
{
if (e.Source != null)
{
Console.WriteLine(ErrorMessages.FormatExceptionDetails(e));
}
}

return output;
Expand All @@ -52,13 +52,13 @@ public static string ToString(object input, string defaultValue = "")
try
{
output = Convert.ToString(input);
}
catch (Exception e)
{
if (e.Source != null)
{
Console.WriteLine("IOException source: {0}", e.Source);
}
}
catch (Exception e)
{
if (e.Source != null)
{
Console.WriteLine(ErrorMessages.FormatExceptionDetails(e));
}
}

return output;
Expand All @@ -76,7 +76,7 @@ public static double ToDouble(object input)
{
if (e.Source != null)
{
Console.WriteLine("IOException source: {0}", e.Source);
Console.WriteLine(ErrorMessages.FormatExceptionDetails(e));
}
}

Expand All @@ -90,15 +90,15 @@ public static decimal ToDecimal(object input)
try
{
output = Convert.ToDecimal(input);
}
catch (Exception e)
{
if (e.Source != null)
{
Console.WriteLine("IOException source: {0}", e.Source);
}
}

}
catch (Exception e)
{
if (e.Source != null)
{
Console.WriteLine(ErrorMessages.FormatExceptionDetails(e));
}
}
return output;
}

Expand All @@ -109,20 +109,20 @@ public static DateTime ToDateTime(object input)
try
{
output = DateTime.Parse(ContentstackConvert.ToString(input));
}
catch (Exception e)
{
if (e.Source != null)
{
Console.WriteLine("IOException source: {0}", e.Source);
}
}

}
catch (Exception e)
{
if (e.Source != null)
{
Console.WriteLine(ErrorMessages.FormatExceptionDetails(e));
}
}
return output;
}

public static string ToISODate(object input)
{
{
DateTime now = DateTime.Now;
try
{
Expand All @@ -132,7 +132,7 @@ public static string ToISODate(object input)
{
if (e.Source != null)
{
Console.WriteLine("IOException source: {0}", e.Source);
Console.WriteLine(ErrorMessages.FormatExceptionDetails(e));
}
}
return now.ToString("yyyy'-'MM'-'dd'T'HH':'mm':'sszzz");
Expand Down Expand Up @@ -186,7 +186,7 @@ public static object GetValue(string value)
{
if (e.Source != null)
{
Console.WriteLine("IOException source: {0}", e.Source);
Console.WriteLine(ErrorMessages.FormatExceptionDetails(e));
}
}

Expand Down Expand Up @@ -222,8 +222,8 @@ public static RegexOptions GetRegexOptions(string option)
return RegexOptions.None;
}
}
}

}
public static Stream GenerateStreamFromString(string s)
{
MemoryStream stream = new MemoryStream();
Expand All @@ -232,7 +232,7 @@ public static Stream GenerateStreamFromString(string s)
writer.Flush();
stream.Position = 0;
return stream;
}
}

#endregion

Expand Down
Loading
Loading