feat(e2e-web): shared Playwright E2E suite for web SDK implementations [NT-3466]#319
Draft
David Nalchevanidze (nalchevanidze) wants to merge 23 commits into
Draft
feat(e2e-web): shared Playwright E2E suite for web SDK implementations [NT-3466]#319David Nalchevanidze (nalchevanidze) wants to merge 23 commits into
David Nalchevanidze (nalchevanidze) wants to merge 23 commits into
Conversation
- Add playwright.config.mjs with webServer readiness gate, workers=1, and per-assertion timeout to fix headless vs UI mode parity - Add e2e/ with all specs copied from web-sdk_react as a starting point - Update serve:app to use ng serve via PM2 with log-based readiness wait - Add test:e2e:setup shared between headless and UI commands - Add allowedCommonJsDependencies for lodash to suppress build warning Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Align heading selectors with Angular template text ('Auto-observed', 'Manually-observed')
- Use data-testid instead of role+name for consent button ('Grant' vs 'Accept Consent')
- Normalize page event URL to pathname in tracking log so navigation spec matches React behavior
- Count all non-null stream events for rawEventsCount so identify events are included
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…T-3466] Move all E2E specs into a new e2e-web package so React and Angular run the same tests without duplication. Each implementation delegates to e2e-web via BASE_URL and PUBLIC_OPTIMIZATION_ENABLE_PREVIEW_PANEL env vars. Align Angular UI text with React (heading names, consent button label) so a single spec set covers both implementations without per-implementation forks. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ience resolution [NT-3466] Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
David Nalchevanidze (nalchevanidze)
requested review from
Lotfi Anwar L Arif (Lotfi-Arif) and
Charles Hudson (phobetron)
as code owners
Charles Hudson (phobetron)
left a comment
Charles Hudson (phobetron)
left a comment
Collaborator
There was a problem hiding this comment.
The new package is not an implementation of its own, so maybe we should consider moving it to /lib from project root.
If this is not yet intended to be ready, please set it as a draft.
e2e-web scripts no longer hardcode BASE_URL or implementation-specific env vars — each implementation passes them when delegating. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ferences [NT-3466] Use storageState to give each test a fresh context (no cookies, no localStorage) so SDK profile state from previous tests cannot affect audience resolution. Add baseline fallbacks for visitor-type and A/B/C entries that resolve differently across browsers due to fingerprint-based audience classification. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Env vars are passed by parent implementation scripts, not loaded from a local .env. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
All env vars are passed by parent callers, no local .env needed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…[NT-3466] Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ives [NT-3466] Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…to E2E_BASE_URL [NT-3466] Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…3466] Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… E2E scripts [NT-3466] - Switch Angular from ng serve (watch mode) to ng build + http-server (static) on port 3000 - Both implementations now share port 3000, removing the need for E2E_BASE_URL - Rename E2E_BASE_URL back to BASE_URL in playwright.config.mjs - Remove set -a / . ./.env / set +a from test:e2e and test:e2e:ui scripts - Remove curl wait loop from Angular serve script (moved to test:e2e:setup) - Remove E2E_BASE_URL from Angular .env.example Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…E jobs [NT-3466] - Add e2e-web install + playwright install steps to e2e-web-sdk_react CI job - Add new e2e-web-sdk_angular CI job mirroring the React job structure - Add e2e_web_sdk_angular path filter and output to the changes job - Update e2e_web_sdk_react filter to also include implementations/e2e-web/** - Fix artifact paths to point to implementations/e2e-web/ (where Playwright outputs reports) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…h, raise bundle budget [NT-3466] Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…stency [NT-3466] Matches web-sdk_react/.env.example which already has it false. Preview panel tests in live-updates.spec.ts are guarded by isPreviewPanelEnabled and skip when false, so there is no coverage loss. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
angular.json defines import.meta.env as a static empty object {}, so
PUBLIC_OPTIMIZATION_ENABLE_PREVIEW_PANEL is always undefined. The previous
!== 'false' check meant the preview panel was always enabled in Angular.
Switching to === 'true' makes it disabled by default, consistent with the
React implementation and correct for E2E.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ject [NT-3466] process.env references in angular.json define are not evaluated at build time; angular.json only accepts static string literals. The opt-in guard in app.config.ts (=== 'true') is sufficient to keep preview panel off by default. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…stop [NT-3466] When PM2 runs "pnpm --dir lib/mocks serve", killing the PM2 process kills the shell but leaves the tsx child holding port 8000. On the next serve:mocks start, the port is already bound and the mock server crashes with EADDRINUSE, causing all API calls to fail and tests to hang. Running tsx directly makes PM2 own the actual process and SIGTERM reaches it cleanly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…l health-check [NT-3466] Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…00 [NT-3466] - Switch trace from 'on-first-retry' to 'on' locally: with 0 retries no trace files are ever written, causing the UI trace viewer to flood the console with 404/500 errors and preventing tests from running in UI mode. - Add a second webServer entry for port 8000 so Playwright polls and waits for the mocks server before dispatching tests. PM2 start returns immediately after forking the tsx process; without the readiness check the first API call races tsx startup and hangs until the 60s test timeout. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
implementations/e2e-web— standalone Playwright package with all 9 shared web E2E specsweb-sdk_reactandweb-sdk_angulardelegate to it; no duplicated spec filesBASE_URLandPUBLIC_OPTIMIZATION_ENABLE_PREVIEW_PANELso the same specs work against both"Auto Observed Entries","Manually Observed Entries","Accept Consent") to eliminate per-implementation forksbeforeEachfor variant display specsTest plan
pnpm --dir implementations/web-sdk_angular test:e2e→ 78 passedpnpm --dir implementations/web-sdk_react test:e2e→ 72 passed, 6 skipped (preview panel disabled in React)🤖 Generated with Claude Code