fix(security): validate postMessage origins and fix slack middleware path#11094
Open
Mitch Goudy (mgoudy91) wants to merge 1 commit into
Open
fix(security): validate postMessage origins and fix slack middleware path#11094Mitch Goudy (mgoudy91) wants to merge 1 commit into
Mitch Goudy (mgoudy91) wants to merge 1 commit into
Conversation
…path Senders (typeform, slack, smartling, jira standalone): replaced wildcard '*' with document.referrer-based origin so tokens are only sent to the known opener page. Receivers (typeform, slack, smartling, jira): added event.origin checks so fake postMessage injections from other pages are rejected. Slack lambda: changed 'api/tokens' to '/api/tokens' in the middleware mount array — the missing leading slash meant path-to-regexp@0.1.x never matched the route, silently bypassing request verification on POST /api/tokens. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Slack lambda — missing leading slash (APPS-1)
Wildcard postMessage — senders (APPS-2)
All four sender files replaced `'*'` with `document.referrer ? new URL(document.referrer).origin : window.location.origin`:
Wildcard postMessage — receivers (APPS-2)
Added `event.origin` checks to all receivers:
Test plan
🤖 Generated with Claude Code