fix(audit-log-viewer): review fixes — button label, stale comment, forcePathStyle docs#11078
Open
Mitch Goudy (mgoudy91) wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small fixes from a review of Shane's audit-log-viewer submission, targeting the feature branch directly so it can be merged cleanly.
Changes
Page.tsx) — the README consistently uses "Load logs" as the call to action; the button label didn't match.LogStorageProvider(types.ts) — the comment said "S3 is the only impl for now" but Azure and GCS are both fully implemented.forcePathStyledeprecation (s3.ts) —forcePathStyle: trueis deprecated by AWS for buckets created after Sep 2020 and unsupported in some newer opt-in regions. Added a comment explaining the trade-off and how to work around it if an operator hits endpoint errors.No logic changes — all tests should continue to pass as-is.